###Feature/Add extractors and test samples for SQLException #1779

BereKanters · 2024-06-14T23:15:22Z

Introduced feature extractors for SQLException:
- errorCode: Extracts the error code from an SQLException instance.
- sqlState: Extracts the SQL state from an SQLException instance.
- Added test samples to validate the new feature extractors:
- errorCodeFeature: Tests the extraction and validation of the error code.
- sqlStateFeature: Tests the extraction and validation of the SQL state.
- errorCode: Tests grouped assertions for the error code.
- sqlState: Tests grouped assertions for the SQL state.
Note: I tried to work on the KSP Plugin, seeing if I could get it to be autogenerated but ill be needing more help with that.

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

…ndows workflows - Added a new CI workflow using vlsi/github-actions-random-matrix to generate a dynamic matrix for testing on both Ubuntu and Windows with JDK 8 and JDK 11. - Merged existing build steps for Ubuntu and Windows into a single workflow file (ci.yml). - Moved common steps, such as caching the Android jar and compiling, into a separate setup job to improve CI efficiency. - Updated README.md to reflect the new combined CI workflow badge. - Improved test coverage and reduced CI resource usage by leveraging the matrix strategy.

- Added a new patch file

…d Windows workflows updated based on feedback - Added custom matrix generation scripts (`matrix_builder.js` and `matrix.js`) to dynamically generate the matrix for CI jobs. - Configured the GitHub Actions workflow (`ci.yml`) to use the custom matrix generator. - Renamed the `setup` job to `dexer` and included the step to check if Atrium's -jvm.jar can be dexed.

- Introduced feature extractors for SQLException: - errorCode: Extracts the error code from an SQLException instance. - sqlState: Extracts the SQL state from an SQLException instance. - Added test samples to validate the new feature extractors: - errorCodeFeature: Tests the extraction and validation of the error code. - sqlStateFeature: Tests the extraction and validation of the SQL state. - errorCode: Tests grouped assertions for the error code. - sqlState: Tests grouped assertions for the SQL state.

.github/workflows/ci.yml

.github/workflows/matrix.js

.github/workflows/matrix_builder.js

README.md

...ium-api-fluent/src/jvmMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/SQLExceptionFeatures.kt

...src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/SQLExceptionFeaturesSamples.kt

robstoll · 2024-06-15T21:03:57Z

...src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/SQLExceptionFeaturesSamples.kt

+        fails {
+            expect(exception)
+                .errorCode // subject is now of type Int
+                .toEqual(9999) // fails
+                .toBeGreaterThan(1000) // not evaluated/reported because `toEqual` already fails
+            // use `.errorCode { ... }` if you want all assertions evaluated
+        }


I suggest you align the comments along the line of:

Suggested change

fails {

expect(exception)

.errorCode // subject is now of type Int

.toEqual(9999) // fails

.toBeGreaterThan(1000) // not evaluated/reported because `toEqual` already fails

// use `.errorCode { ... }` if you want all assertions evaluated

}

fails {

expect(exception)

.errorCode // subject is now of type Int

.toEqual(9999) // fails

.toBeGreaterThan(1000) // not evaluated/reported because `toEqual` already fails

// use `.errorCode { ... }` if you want all assertions evaluated

}

robstoll · 2024-06-15T21:04:38Z

...src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/SQLExceptionFeaturesSamples.kt

+    @Test
+    fun errorCode() {
+        val exception = SQLException("Test exception", "42000", 1001)
+
+        expect(exception).errorCode { // subject within this expectation-group is of type Int
+            toBeGreaterThan(1000)
+            toEqual(1001)
+        } // subject here is back to type SQLException
+
+        fails {
+            expect(exception).errorCode {
+                toEqual(9999) // fails
+                toBeGreaterThan(1000) // still evaluated even though `toEqual` already fails
+            }
+        }
+    }


please move up right after errorCodeFeature

robstoll · 2024-06-15T21:05:04Z

feature-random-matrix-ci.patch

robstoll · 2024-06-15T21:10:04Z

Note: I tried to work on the KSP Plugin, seeing if I could get it to be autogenerated but ill be needing more help with that.

Nice, I suggest that we postpone that one to a next PR though. I am not convinced we need a KSP plugin as we might want to operate on code we don't actually compile (as in this case, the SQLException was already compiled).

@SInCE

- Added KDoc comments with @SInCE 1.3.0 and links to the sample file. - Changed file naming to `sqlExceptionFeatureExtractors` and `SQLExceptionFeaturesSamples` - Removed accidentally commited files - Aligned comments and ordered fun

…ndows workflows - Added a new CI workflow using vlsi/github-actions-random-matrix to generate a dynamic matrix for testing on both Ubuntu and Windows with JDK 8 and JDK 11. - Merged existing build steps for Ubuntu and Windows into a single workflow file (ci.yml). - Moved common steps, such as caching the Android jar and compiling, into a separate setup job to improve CI efficiency. - Updated README.md to reflect the new combined CI workflow badge. - Improved test coverage and reduced CI resource usage by leveraging the matrix strategy.

- Added a new patch file

…d Windows workflows updated based on feedback - Added custom matrix generation scripts (`matrix_builder.js` and `matrix.js`) to dynamically generate the matrix for CI jobs. - Configured the GitHub Actions workflow (`ci.yml`) to use the custom matrix generator. - Renamed the `setup` job to `dexer` and included the step to check if Atrium's -jvm.jar can be dexed.

- Introduced feature extractors for SQLException: - errorCode: Extracts the error code from an SQLException instance. - sqlState: Extracts the SQL state from an SQLException instance. - Added test samples to validate the new feature extractors: - errorCodeFeature: Tests the extraction and validation of the error code. - sqlStateFeature: Tests the extraction and validation of the SQL state. - errorCode: Tests grouped assertions for the error code. - sqlState: Tests grouped assertions for the SQL state.

@SInCE

- Added KDoc comments with @SInCE 1.3.0 and links to the sample file. - Changed file naming to `sqlExceptionFeatureExtractors` and `SQLExceptionFeaturesSamples` - Removed accidentally commited files - Aligned comments and ordered fun

…s Workflows (robstoll#1776) * ###feature/Integrate random matrix generation and merge Ubuntu and Windows workflows - Added a new CI workflow using vlsi/github-actions-random-matrix to generate a dynamic matrix for testing on both Ubuntu and Windows with JDK 11 and JDK 17 - Merged existing build steps for Ubuntu and Windows into a single workflow file.

…com/BereKanters/atrium into feature/extractors-for-SQLException

- Removed comment from constructor

- Added comment to constructor - Added this.namePattern = [];

- Added Requires java to module-info.java

- Introduced feature extractors for SQLException: - errorCode: Extracts the error code from an SQLException instance. - sqlState: Extracts the SQL state from an SQLException instance.

codecov · 2024-06-16T21:39:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (9c560e9) to head (552f710).
Report is 44 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1779   +/-   ##
=========================================
  Coverage     92.73%   92.74%           
  Complexity      116      116           
=========================================
  Files           442      443    +1     
  Lines          4941     4945    +4     
  Branches        234      234           
=========================================
+ Hits           4582     4586    +4     
  Misses          312      312           
  Partials         47       47

Flag	Coverage Δ
current	`92.46% <100.00%> (+<0.01%)`	⬆️
current_windows	`91.50% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robstoll · 2024-06-17T07:59:17Z

...luent/src/jvmMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/sqlExceptionFeatureExtractors.kt

+import java.sql.SQLException
+
+/**
+ * Extracts the [errorCode][SQLException.getErrorCode] property from the subject of the assertion.


Please copy the kdoc from collectionFeatureExtractors.kt -> val size and adopt. I prefer if they are all the same, this way changes in the future can be made via search and replace.

robstoll · 2024-06-17T20:09:43Z

...luent/src/jvmMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/sqlExceptionFeatureExtractors.kt

+    get() = feature("errorCode", SQLException::getErrorCode)
+
+/**
+ * Extracts the [errorCode][SQLException.getErrorCode] property from the subject of the assertion and makes it the new subject.


Also here, please copy the KDoc from collectionFeatureExtractors.kt -> fun size

robstoll · 2024-06-17T20:12:02Z

apis/fluent/atrium-api-fluent/api/main/atrium-api-fluent.api

@@ -518,6 +518,13 @@ public final class ch/tutteli/atrium/api/fluent/en_GB/SequenceSubjectChangersKt
 	public static final fun asList (Lch/tutteli/atrium/creating/Expect;Lkotlin/jvm/functions/Function1;)Lch/tutteli/atrium/creating/Expect;
 }

+public final class ch/tutteli/atrium/api/fluent/en_GB/SqlExceptionFeatureExtractorsKt {


you also need to generate the api for Kotlin 1.9 and newer. Run KOTLIN_VERSION=1.9 ./gradlew apiDump to achieve this (or copy those lines over to using-kotlin-1.9-or-newer/atrium-api-fluent.api).

robstoll · 2024-08-20T06:20:30Z

@BereKanters please let me know in case you need help

robstoll · 2024-08-21T12:56:10Z

@hubtanaka would you like to take this one over? I guess @BereKanters doesn't have time to finish it.

hubtanaka · 2024-08-21T13:35:34Z

@robstoll Yes. I'll work on this.

hubtanaka · 2024-08-23T10:52:17Z

@robstoll
I created new PR for this issue.
#1820

by the way, I didn't find out how to commit here directly because I'm not familiar with GitHub yet.
So I wonder that this is a correct way to do on GitHub.
please let me know if there is more effective something to take over and proceed this PR.

robstoll · 2024-08-23T11:35:54Z

Creating a new PR was the correct why as you would need to have access to Berekaners repository if you wanted to commit here directly. Closing this in favour of the new PR

hubtanaka · 2024-08-23T12:02:46Z

Thank you so much

BereKanters added 4 commits June 11, 2024 13:22

###feature/Added feature-random-matrix-ci.patch file

076c136

- Added a new patch file

BereKanters requested a review from robstoll as a code owner June 14, 2024 23:15

robstoll requested changes Jun 15, 2024

View reviewed changes

BereKanters requested a review from robstoll June 15, 2024 23:35

BereKanters and others added 12 commits June 16, 2024 17:50

Merge branch 'robstoll:main' into feature/extractors-for-SQLException

aab9b3f

###feature/Added feature-random-matrix-ci.patch file

fcdcf8c

- Added a new patch file

Merge branch 'feature/extractors-for-SQLException' of https://github.…

0a9ab8a

…com/BereKanters/atrium into feature/extractors-for-SQLException

###Fix/Removed non needed comment

904b2e1

- Removed comment from constructor

###Fix/Re-added comment

4521ddb

- Added comment to constructor - Added this.namePattern = [];

###Fix/Added Requires java to module for sqlExceptionFeatureExtractors

d400a45

- Added Requires java to module-info.java

###Feat/Updated API declarations for new SQLException feature extractors

552f710

- Introduced feature extractors for SQLException: - errorCode: Extracts the error code from an SQLException instance. - sqlState: Extracts the SQL state from an SQLException instance.

robstoll reviewed Jun 17, 2024

View reviewed changes

hubtanaka mentioned this pull request Aug 23, 2024

###Feature/Add extractors and test samples for SQLException (Took over) #1820

Merged

4 tasks

robstoll closed this Aug 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

###Feature/Add extractors and test samples for SQLException #1779

###Feature/Add extractors and test samples for SQLException #1779

BereKanters commented Jun 14, 2024

robstoll Jun 15, 2024

robstoll Jun 15, 2024

robstoll Jun 15, 2024

robstoll commented Jun 15, 2024

codecov bot commented Jun 16, 2024 •

edited

Loading

robstoll Jun 17, 2024 •

edited

Loading

robstoll Jun 17, 2024

robstoll Jun 17, 2024 •

edited

Loading

robstoll commented Aug 20, 2024

robstoll commented Aug 21, 2024

hubtanaka commented Aug 21, 2024

hubtanaka commented Aug 23, 2024

robstoll commented Aug 23, 2024

hubtanaka commented Aug 23, 2024

###Feature/Add extractors and test samples for SQLException #1779

###Feature/Add extractors and test samples for SQLException #1779

Conversation

BereKanters commented Jun 14, 2024

robstoll Jun 15, 2024

Choose a reason for hiding this comment

robstoll Jun 15, 2024

Choose a reason for hiding this comment

robstoll Jun 15, 2024

Choose a reason for hiding this comment

robstoll commented Jun 15, 2024

codecov bot commented Jun 16, 2024 • edited Loading

Codecov Report

robstoll Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

robstoll Jun 17, 2024

Choose a reason for hiding this comment

robstoll Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

robstoll commented Aug 20, 2024

robstoll commented Aug 21, 2024

hubtanaka commented Aug 21, 2024

hubtanaka commented Aug 23, 2024

robstoll commented Aug 23, 2024

hubtanaka commented Aug 23, 2024

codecov bot commented Jun 16, 2024 •

edited

Loading

robstoll Jun 17, 2024 •

edited

Loading

robstoll Jun 17, 2024 •

edited

Loading